Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hold notes on downscroll #2488

Merged
merged 3 commits into from
May 29, 2024
Merged

Fix hold notes on downscroll #2488

merged 3 commits into from
May 29, 2024

Conversation

MaybeMaru
Copy link
Contributor

Fixes the position of hold notes on downscroll to be on the correct center of the note and strum

Before After
before after

@gamerbross
Copy link
Contributor

i thought this was intended, but please move this to be consistent 🙏 🙏
image

@MaybeMaru
Copy link
Contributor Author

sure one sec

@amyspark-ng
Copy link
Contributor

wasn't this fixed in 0.3.3?

@MaybeMaru
Copy link
Contributor Author

wasn't this fixed in 0.3.3?

It fixed the sustains flickering problem, not this

@ninjamuffin99 ninjamuffin99 added this to the 0.4.0 milestone May 24, 2024
@ninjamuffin99 ninjamuffin99 self-requested a review May 24, 2024 20:19
@EliteMasterEric EliteMasterEric self-assigned this May 29, 2024
@EliteMasterEric
Copy link
Member

nice pfp

@EliteMasterEric EliteMasterEric merged commit 34ca8dc into FunkinCrew:develop May 29, 2024
@MaybeMaru MaybeMaru deleted the downscroll branch June 7, 2024 17:37
@EliteMasterEric EliteMasterEric mentioned this pull request Jun 17, 2024
Closed
6 tasks
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. topic: polish Involves minor polish to the UI or gameplay. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninjamuffin99 ninjamuffin99 Awaiting requested review from ninjamuffin99

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: polish Involves minor polish to the UI or gameplay. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MaybeMaru @gamerbross @amyspark-ng @EliteMasterEric @ninjamuffin99 @Hundrec