Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] ChartingState GameOver Crashes #2518

Merged
merged 1 commit into from
May 18, 2024
Merged

[BUGFIX] ChartingState GameOver Crashes #2518

merged 1 commit into from
May 18, 2024

Conversation

gamerbross
Copy link
Contributor

Leaving Game Over screen while playtesting from Charting crashed the game.
Also dying when minimal mode crashed.

@EliteMasterEric
Copy link
Member

Looks good.

@EliteMasterEric EliteMasterEric merged commit 6744c1d into FunkinCrew:develop May 18, 2024
@gamerbross gamerbross deleted the bugfix/gameover-charting-crash branch May 18, 2024 19:02
superpowers04 pushed a commit to superpowers04/Super-Funkin that referenced this pull request May 18, 2024
@EliteMasterEric @superpowers04
Merge pull request FunkinCrew#2518 from gamerbross/bugfix/gameover-ch…
3408c14 
…arting-crash

[BUGFIX] ChartingState GameOver Crashes
@EliteMasterEric EliteMasterEric mentioned this pull request May 22, 2024
Closed
8 tasks
@EliteMasterEric EliteMasterEric added this to the 0.4.0 milestone Jun 7, 2024
@Hundrec Hundrec added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. size: small A small pull request with 10 or fewer changes. topic: chart editor Related to the operation of the Chart Editor. pr: haxe PR modifies game code. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gamerbross @EliteMasterEric @Hundrec