Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX/ENHANCEMENT] Changes instances of FlxG.mouse.screen(x/y) to FlxG.mouse.view(x/y) in ChartEditorState.hx (and more) #3337

Merged
merged 4 commits into from
Sep 30, 2024
Merged

[BUGFIX/ENHANCEMENT] Changes instances of FlxG.mouse.screen(x/y) to FlxG.mouse.view(x/y) in ChartEditorState.hx (and more) #3337

merged 4 commits into from
Sep 30, 2024

Conversation

Kade-github
Copy link
Contributor

@Kade-github Kade-github commented Sep 17, 2024 •
edited
Loading

Does this PR close any issues? If so, link them below.

Fixes #3147,

Briefly describe the issue(s) fixed.

Changes any instance of screenX/screenY to viewX/viewY as the former is depreciated. Causing the editor to not function due to HaxeFlixel/flixel#3210

Also adds a millisecond part of the playbar :D

Include any relevant screenshots or videos.

image

@Kade-github
add milliseconds to the playbar in charting state
535ac0e 
remove laggy redundant traces

Revert "remove laggy redundant traces"

This reverts commit 2041138.
@Kade-github
only show last two digits
5a877a1 
digit
@Kade-github
depreciated screen X/Y to view X/Y
7d2b946
@EliteMasterEric EliteMasterEric self-assigned this Sep 17, 2024
@EliteMasterEric EliteMasterEric self-requested a review September 17, 2024 00:20
@EliteMasterEric EliteMasterEric added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression status: reviewing internally Under consideration and testing. topic: chart editor Related to the operation of the Chart Editor. labels Sep 17, 2024
@Kade-github Kade-github changed the title [ENHANCEMENT] Changes instance of FlxG.mouse.screen(x/y) to FlxG.mouse.view(x/y) in ChartEditorState.hx (and more) [ENHANCEMENT] Changes instances of FlxG.mouse.screen(x/y) to FlxG.mouse.view(x/y) in ChartEditorState.hx (and more) Sep 17, 2024
@Kade-github Kade-github changed the title [ENHANCEMENT] Changes instances of FlxG.mouse.screen(x/y) to FlxG.mouse.view(x/y) in ChartEditorState.hx (and more) [BUGFIX/ENHANCEMENT] Changes instances of FlxG.mouse.screen(x/y) to FlxG.mouse.view(x/y) in ChartEditorState.hx (and more) Sep 17, 2024
ImCodist
ImCodist approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ImCodist ImCodist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes!

EliteMasterEric
EliteMasterEric approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 17, 2024
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Sep 17, 2024
@Kade-github Kade-github mentioned this pull request Sep 17, 2024
Closed
2 tasks
Hazardous2468 added a commit to Hazardous2468/What-In-The-Funkin that referenced this pull request Sep 18, 2024
@Hazardous2468
Chart editor fix plus new character save fix
402cdcd 
FunkinCrew#3337
@AbnormalPoof AbnormalPoof mentioned this pull request Sep 21, 2024
Open
2 tasks
@EliteMasterEric EliteMasterEric changed the base branch from main to develop September 25, 2024 12:56
@ninjamuffin99 ninjamuffin99 merged commit 9624b57 into FunkinCrew:develop Sep 30, 2024
@tposejank
Copy link
Contributor

Yay

@Hundrec Hundrec added the size: medium A medium pull request with 100 or fewer changes. label Jan 22, 2025
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

@NotHyper-474 NotHyper-474 NotHyper-474 approved these changes

@ImCodist ImCodist ImCodist approved these changes

@cyn0x8 cyn0x8 cyn0x8 approved these changes

@rodney528 rodney528 rodney528 approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@tposejank tposejank tposejank approved these changes

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

@JVNpixels JVNpixels JVNpixels approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

Bug Report: Chart Editor is completely broken (does not allow placing notes)