Fixed F1 spamming in chart editor #3552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesisfeline
approved these changes
Oct 3, 2024
NotHyper-474
approved these changes
Oct 3, 2024
|
yippe!! |
Hundrec
approved these changes
Oct 3, 2024
|
Get this Amy a True... |
ninjamuffin99
force-pushed
the
develop
branch
2 times, most recently
from
e0b1b01 to
410cfe9
Compare
|
guessing it was merged, yippee!! |
|
my bad i just fuked up da rebase im still learnin |
8 tasks
|
oh it's ok i was really confused yesterday when i saw all that git rebasing stuff happening do i make a new pr with the same changes to reopen it or? |
|
oh wait no it already got merged, thank you! |
AbnormalPoof
added
the
status: rejected
|
@AbnormalPoof This PR wasn't rejected, it was just merged in a weird way. |
Hundrec
added
status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
This would close #2429 which has been a thing since 0.3.0 lol!
Briefly describe the issue(s) fixed.
There was an issue where the game would let you spam F1 to open the help dialogue several times, including over other dialogs
Checking if isHaxeUIDialogOpen is false would make it so you can't open it more than once or in other dialogs, hope i did well i couldn't really test it because compiling fnf would be hell for my computer
Include any relevant screenshots or videos.