API Key Expiration Updates #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooreds
reviewed
Dec 24, 2024
mooreds
reviewed
Dec 24, 2024
…arles/api-key-expiration-updates # Conflicts: # astro/src/content/docs/apis/_tenant-authentication.mdx # astro/src/content/docs/apis/authentication.mdx
|
FYI the and I am disappointed with myself that I did not make the message say "strong bad!" |
spwitt
requested changes
Jan 2, 2025
…arles/api-key-expiration-updates
…tes' into dcharles/api-key-expiration-updates
spwitt
requested changes
Jan 3, 2025
spwitt
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
The changes look good, but I see a check_apis failure.
MISSING FIELDS
{:original_examined_type=>"apiKey", :full_field_name=>"apiKey.expirationInstant", :type=>"ZonedDateTime"}
It seems like you have covered that field though, so I'm not sure where it's getting the missing field from.
|
The api check is failing on main, I would ignore that here as that wasn't you |
lyleschemmerling
approved these changes
Jan 3, 2025
|
As a reminder, you can always run the api check script against a local instance of the client builder and of the website. The script has a The github action runs against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Key API and Management documentation updates for new API key expiration functionality.