Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse search fix #381

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Inverse search fix #381

merged 2 commits into from
Mar 28, 2019

Conversation

achilleas-k
Copy link
Member

Found (and fixed) a bug in the inverse search when there were objects in the file that did not have a metadata link.

Causes error when objects exist that have no metadata and the search
tries to compare their IDs
Check if the object actually has a link to a metadata section (not None)
before trying to compare the ID.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 89.63% when pulling 5cf9d3a on achilleas-k:inverse-search-fix into 91628d0 on G-Node:master.

Copy link
Member

@gicmo gicmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jgrewe jgrewe merged commit 50a156e into G-Node:master Mar 28, 2019
@achilleas-k achilleas-k deleted the inverse-search-fix branch March 29, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants