-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Property values] Add append_values method for modifying values #392
Conversation
I guess we need a test case for that :) |
I was wondering if there was a more pythonic way to do this and I realised that, since So this doesn't work: prop.values.append(10) because prop.values += (10,) because you can concatenate tuples with It's essentially equivalent to v = prop.values
v += (10,)
prop.values = v and our Line 273 in ef2637c
I suppose it might still be useful for users to have an EDIT: The append/extend methods could probably check if the new data is the same type (or can be upgraded to the type) of the existing data. If users use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Refer to Issue #382.