Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator part 2 #421

Merged
merged 28 commits into from
Oct 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
10454f0
[validator] Module functions instead of class
achilleas-k Oct 8, 2019
3eb1c8f
[validator] New Block and Group check functions
achilleas-k Oct 8, 2019
62f83ed
[validator] Update block validation test
achilleas-k Oct 9, 2019
cb89a68
[validator] Clean up group validation and test
achilleas-k Oct 9, 2019
2fd5002
[validator] Validation functions return lists
achilleas-k Oct 9, 2019
d716472
[validator] Check DataArrays and Dimensions
achilleas-k Oct 9, 2019
6e0ae8e
[validator] Clean up imports
achilleas-k Oct 10, 2019
18604af
[validator] Simplify get_dim_units helper func
achilleas-k Oct 10, 2019
424389d
[validator] Remove old Validator class
achilleas-k Oct 10, 2019
fcb5c0f
[validator] Check Tags
achilleas-k Oct 10, 2019
f1c1490
[validator] Fix some logical errors
achilleas-k Oct 10, 2019
a622788
[validator] Cleaner (and correct) unit match checking
achilleas-k Oct 10, 2019
20d72eb
[validator] Test rewrite
achilleas-k Oct 10, 2019
bae3228
[validator] Check MultiTags
achilleas-k Oct 10, 2019
369e459
[validator] Test MultiTags
achilleas-k Oct 10, 2019
7ac491b
[validator] Static classes for error and warning strings
achilleas-k Oct 10, 2019
f2c703f
[validator] More tests (File and DataArray)
achilleas-k Oct 10, 2019
07381fb
[validator] Allow creation date to be = 0
achilleas-k Oct 11, 2019
6f50212
[validator] Check features and sources
achilleas-k Oct 11, 2019
fdd2fb8
[validator] Check Sections and Properties
achilleas-k Oct 12, 2019
87fa6a7
[validator] Add Sections and Properties to test file
achilleas-k Oct 12, 2019
d81993a
[validator] Tests for Section and Property
achilleas-k Oct 12, 2019
b6042c5
[validator] Tests for Dimension errors and warnings
achilleas-k Oct 12, 2019
7b3c338
Delete unused debugging function in validator test
achilleas-k Oct 12, 2019
307dccd
Delete unused code and import
achilleas-k Oct 12, 2019
305d795
Fix cyclic import warning
achilleas-k Oct 12, 2019
5ed05de
[validator] Move closure to outermost valid scope
achilleas-k Oct 13, 2019
a7fd01c
[validator] Don't check dimension_type
achilleas-k Oct 13, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nixio/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from .feature import Feature
from .data_frame import DataFrame
from .dimensions import SampledDimension, RangeDimension, SetDimension
from . import validator

# enums
from .file import FileMode
Expand All @@ -36,6 +37,6 @@
"MultiTag", "Source", "Section", "S", "Feature", "Property",
"OdmlType", "SampledDimension", "RangeDimension", "SetDimension",
"FileMode", "DataSliceMode", "DataType", "DimensionType",
"LinkType", "Compression")
"LinkType", "Compression", "validator")
__author__ = ('Christian Kellner, Adrian Stoewer, Andrey Sobolev, Jan Grewe, '
'Balint Morvai, Achilleas Koutsou')
49 changes: 2 additions & 47 deletions nixio/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@
from . import util
from .exceptions import InvalidFile, DuplicateName
from .util import find as finders
from .validate import Validate
from . import validator
from .compression import Compression
from .dimensions import RangeDimension, SetDimension, SampledDimension


FILE_FORMAT = "nix"
Expand Down Expand Up @@ -283,51 +282,7 @@ def is_open(self):
return False

def validate(self):
"""
Checks if the file is a valid nix file.

:returns: A dict which contains all objects in file and related errors
:rtype: Dictionary
"""
validator = Validate(self)
validator.check_file()
validator.form_dict()
errors = validator.errors
for bi, blk in enumerate(self.blocks):
validator.check_blocks(blk, bi)
for gi, grp in enumerate(blk.groups):
validator.check_groups(grp, gi, bi)
for di, da in enumerate(blk.data_arrays):
validator.check_data_arrays(da, di, bi)
for dimi, dim in enumerate(da.dimensions):
if isinstance(dim, RangeDimension):
validator.check_range_dim(dim, dimi, di, bi)
if isinstance(dim, SetDimension):
validator.check_set_dim(dim, dimi, di, bi)
if isinstance(dim, SampledDimension):
validator.check_sampled_dim(dim, dimi, di, bi)
for mti, mt in enumerate(blk.multi_tags):
validator.check_multi_tag(mt, mti, bi)
for fi, fea in enumerate(mt.features):
validator.check_features(fea, 'multi_tags', bi, mti, fi)
for ti, tag in enumerate(blk.tags):
validator.check_tag(tag, ti, bi)
for fi, fea in enumerate(tag.features):
validator.check_features(fea, 'tags', bi, ti, fi)
for src in blk.find_sources():
validator.check_sources(src, bi)

for si, sec in enumerate(self.find_sections()):
validator.check_section(sec, si)
for pi, prop in enumerate(sec.props):
validator.check_property(prop, pi, si)

if validator.error_count:
print("{} errors found".format(validator.error_count))
return errors
else:
print("No errors found: The file is a valid NIX file")
return errors
return validator.check_file(self)

def pprint(self, indent=2, max_length=120, extra=True, max_depth=3):
"""
Expand Down
Loading