Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for h5group.root #434

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Fix bug for h5group.root #434

merged 2 commits into from
Mar 6, 2020

Conversation

hkchekc
Copy link
Member

@hkchekc hkchekc commented Mar 5, 2020

Originally the function won't work, now we can get nix Blocks or Sections from h5group. Probably need some test

@hkchekc hkchekc requested a review from achilleas-k March 5, 2020 18:06
@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2020

This pull request fixes 1 alert when merging 8917e51 into b19e5ad - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a class instantiation

@achilleas-k achilleas-k changed the title Fix big for h5group.root Fix bug for h5group.root Mar 6, 2020
@achilleas-k
Copy link
Member

Looks good. Will merge when tests finish.

@lgtm-com
Copy link

lgtm-com bot commented Mar 6, 2020

This pull request fixes 1 alert when merging 3ca2484 into ed22c88 - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a class instantiation

@btel
Copy link
Member

btel commented Mar 6, 2020

Codecov Report

Merging #434 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   90.42%   90.41%   -0.02%     
==========================================
  Files          55       55              
  Lines        7090     7091       +1     
==========================================
  Hits         6411     6411              
- Misses        679      680       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed22c88...3ca2484. Read the comment docs.

@achilleas-k achilleas-k merged commit 5275a39 into G-Node:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants