Fixes and simplifications for DataTypes and DataType mappings #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
achilleas-k
commented
May 8, 2020
achilleas-k
commented
- Added DataType groups (integers and floats) to simplify data type detection and mapping.
- Small fixes for mapping between odML and NIX property DataTypes.
- DataType.get_dtype() returns Double for all floating point values (see Inserting odML float property #463).
One for all Integers and one for the Floats. Simplifies the function for numeric detection, but it's probably unnecessary now.
DataType.get_dtype() returns Double for all floating point values. Fixes G-Node#463.
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.