-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Range dim #503
Range dim #503
Conversation
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 78.71% 78.76% +0.04%
==========================================
Files 59 59
Lines 9278 9342 +64
==========================================
+ Hits 7303 7358 +55
- Misses 1975 1984 +9
Continue to review full report at Codecov.
|
automatically created index is now as long as the rank of the linked DataArray.
@achilleas-k guess this is ready for review ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. Approved, though I have one question I'm not sure about.
fixes
DimensionLink.id
SampledDimension.axis
returned the wrong number of data points (off by 1 due to rounding issues under certain conditions)adds
RangeDimension.is_alias
method for downward compatibilityDataArray.append_range_dimension_using_self
as a convenience method