Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range dim #503

Merged
merged 14 commits into from
Jun 13, 2021
Merged

Range dim #503

merged 14 commits into from
Jun 13, 2021

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Jun 4, 2021

fixes

  • missing return in DimensionLink.id
  • a few docstrings
  • the version number in appveyor.yml
  • SampledDimension.axis returned the wrong number of data points (off by 1 due to rounding issues under certain conditions)

adds

  • RangeDimension.is_alias method for downward compatibility
  • DataArray.append_range_dimension_using_self as a convenience method

@coveralls
Copy link

coveralls commented Jun 5, 2021

Coverage Status

Coverage increased (+0.05%) to 79.027% when pulling a29fe7c on jgrewe:range_dim into d1a9f70 on G-Node:master.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

Merging #503 (a29fe7c) into master (d1a9f70) will increase coverage by 0.04%.
The diff coverage is 86.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   78.71%   78.76%   +0.04%     
==========================================
  Files          59       59              
  Lines        9278     9342      +64     
==========================================
+ Hits         7303     7358      +55     
- Misses       1975     1984       +9     
Impacted Files Coverage Δ
nixio/dimensions.py 91.40% <74.35%> (-1.67%) ⬇️
nixio/data_array.py 91.66% <100.00%> (+0.61%) ⬆️
nixio/test/test_dimensions.py 99.75% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9f70...a29fe7c. Read the comment docs.

@jgrewe jgrewe marked this pull request as ready for review June 5, 2021 16:14
automatically created index is now as long as the rank of the linked DataArray.
@jgrewe
Copy link
Member Author

jgrewe commented Jun 7, 2021

@achilleas-k guess this is ready for review ;)

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Approved, though I have one question I'm not sure about.

nixio/dimensions.py Show resolved Hide resolved
@achilleas-k achilleas-k merged commit 8dcb254 into G-Node:master Jun 13, 2021
@jgrewe jgrewe deleted the range_dim branch June 14, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants