Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[block] add label and unit as optional args for array creation #505

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Jun 17, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #505 (3e225a4) into master (91df1f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   78.74%   78.76%   +0.01%     
==========================================
  Files          59       59              
  Lines        9343     9351       +8     
==========================================
+ Hits         7357     7365       +8     
  Misses       1986     1986              
Impacted Files Coverage Δ
nixio/block.py 73.28% <100.00%> (+0.17%) ⬆️
nixio/test/test_block.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91df1f8...3e225a4. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 17, 2021

Coverage Status

Coverage increased (+0.02%) to 79.026% when pulling 3e225a4 on jgrewe:array_create into 91df1f8 on G-Node:master.

achilleas-k
achilleas-k previously approved these changes Jun 21, 2021
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constructors are getting a bit unwieldy, but I suppose it's all optional so it's fine.

@jgrewe
Copy link
Member Author

jgrewe commented Jun 21, 2021

@achilleas-k when writing the example files for the python docs, the two lines to add unit and label were among the most annoying...
Closing and reopening to trigger appveyor

@jgrewe jgrewe closed this Jun 21, 2021
@jgrewe jgrewe reopened this Jun 21, 2021
@mpsonntag mpsonntag merged commit 450391f into G-Node:master Jun 22, 2021
@jgrewe jgrewe deleted the array_create branch June 22, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants