Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perform python version checks in cmd/main ... #519

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Jul 18, 2021

... will raise a runtime error if python version is below 3.6
... will create argparse.add_subparsers without requires=True for python 3.6
... and will use it for python >= 3.7

fixes #518

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 78.998% when pulling ab6bb7e on jgrewe:cmd_required into f2c0cd6 on G-Node:master.

@codecov-commenter
Copy link

Codecov Report

Merging #519 (ab6bb7e) into master (f2c0cd6) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   78.77%   78.73%   -0.05%     
==========================================
  Files          59       59              
  Lines        9386     9391       +5     
==========================================
  Hits         7394     7394              
- Misses       1992     1997       +5     
Impacted Files Coverage Δ
nixio/cmd/main.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c0cd6...ab6bb7e. Read the comment docs.

@achilleas-k achilleas-k merged commit 3d4f21e into G-Node:master Jul 20, 2021
@jgrewe jgrewe deleted the cmd_required branch July 20, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error upgrading file on py3.6
4 participants