Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dim label #522

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Set dim label #522

merged 3 commits into from
Aug 11, 2021

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Aug 8, 2021

as we discussed, this pr adds a label for SetDimensions

As this is a non-breaking change to the model the file format version is increased to 1.2.1

jgrewe added 2 commits August 8, 2021 13:51
in addition to the labels for the individual entries along the dimension

This is a non-breaking change to the model.
@codecov-commenter
Copy link

Codecov Report

Merging #522 (ad5be25) into master (724c663) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   81.25%   81.29%   +0.04%     
==========================================
  Files          81       81              
  Lines       10538    10561      +23     
==========================================
+ Hits         8563     8586      +23     
  Misses       1975     1975              
Impacted Files Coverage Δ
nixio/data_array.py 91.66% <100.00%> (ø)
nixio/dimensions.py 91.46% <100.00%> (+0.14%) ⬆️
nixio/file.py 88.46% <100.00%> (ø)
nixio/test/test_dimensions.py 99.54% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ae900...ad5be25. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 8, 2021

Coverage Status

Coverage increased (+0.01%) to 79.599% when pulling 63e0e04 on jgrewe:set_dim_label into 14ccf08 on G-Node:master.

Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mpsonntag mpsonntag merged commit c5ffc3b into G-Node:master Aug 11, 2021
@jgrewe jgrewe deleted the set_dim_label branch August 11, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants