-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pprint] max_depth=-1 is now default #523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
- Coverage 81.28% 81.26% -0.02%
==========================================
Files 81 81
Lines 10741 10741
==========================================
- Hits 8731 8729 -2
- Misses 2010 2012 +2
Continue to review full report at Codecov.
|
Needs a rebase. |
@achilleas-k thanks for pinging... Will do but I also need to (re)consider the side effect of this choice on the nixio command line tool, which will then print out the whole metadata tree. |
I think it's fine to spew everything out by default. It might be a bit annoying, but no more than any other command line tool that produces multiple pages of output by default. |
@achilleas-k rebased ;) |
Needs another rebase 😄 |
rebased again ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(naughty whitespace changes ;)
No description provided.