Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pprint] max_depth=-1 is now default #523

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Aug 11, 2021

No description provided.

mpsonntag
mpsonntag previously approved these changes Aug 11, 2021
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #523 (92d44db) into master (46d1595) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   81.28%   81.26%   -0.02%     
==========================================
  Files          81       81              
  Lines       10741    10741              
==========================================
- Hits         8731     8729       -2     
- Misses       2010     2012       +2     
Impacted Files Coverage Δ
nixio/property.py 78.57% <66.66%> (ø)
nixio/section.py 85.66% <100.00%> (ø)
docs/source/examples/spikeFeatures.py 95.40% <0.00%> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d1595...92d44db. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 11, 2021

Coverage Status

Coverage remained the same at 79.661% when pulling 940af84 on jgrewe:max_depth into 10d48b4 on G-Node:master.

achilleas-k
achilleas-k previously approved these changes Sep 7, 2021
@achilleas-k
Copy link
Member

Needs a rebase.

@jgrewe
Copy link
Member Author

jgrewe commented Sep 7, 2021

@achilleas-k thanks for pinging... Will do but I also need to (re)consider the side effect of this choice on the nixio command line tool, which will then print out the whole metadata tree.
Is that a bad choice? I am not sure. If yes, then I will limit the default recursion depth there.
What do you think?

@achilleas-k
Copy link
Member

I think it's fine to spew everything out by default. It might be a bit annoying, but no more than any other command line tool that produces multiple pages of output by default.

@jgrewe
Copy link
Member Author

jgrewe commented Oct 21, 2021

@achilleas-k rebased ;)

@achilleas-k
Copy link
Member

@achilleas-k rebased ;)

Needs another rebase 😄
Sorry, I should have merged sooner

@jgrewe
Copy link
Member Author

jgrewe commented Oct 25, 2021

rebased again ;)

Copy link
Member

@gicmo gicmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(naughty whitespace changes ;)

@mpsonntag mpsonntag merged commit 8bfbb4c into G-Node:master Oct 26, 2021
@jgrewe jgrewe deleted the max_depth branch October 26, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants