-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finish six removal #544
finish six removal #544
Conversation
@@ -105,7 +105,7 @@ def update_info(newver): | |||
infodict = json.load(infofile) | |||
|
|||
verstring = infodict["VERSION"] | |||
newverstring = re.sub("[0-9\.a-z]+", newver, verstring) | |||
newverstring = re.sub(r"[0-9\.a-z]+", newver, verstring) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sligthly unrelated, but useful nonetheless, these r"" raw strings will fix a bunch of SyntaxWarnings which would stem to the failure to translate the escape code "\." in this particular case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I always run pyflakes
before submitting a PR; and the warnings were there, so ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged, I guess that explains it and the programming languages selection in setup.py. :)
Thanks Alexandre for the follow-up changes to remove traces of six! I went through your changes and I believe they are sound, but I am only a passer-by contributor to nixio/nixpy, so better wait for main upstream authors to comment. Have a nice day, :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. ensure_str()
could be a utility function so it's not duplicated but that's minor and we can do it in a separate PR.
We ll ... ensure_str() was there in the first place because the Py2 was not sure what is was getting. This could be removed after carefully auditing wether these are internal API with safe input or API that might get unexpected data from callers. This kind of audit can be greatly aided by adding type annotations all over the place and running But many people feel that type annotations doesn't belong in Python. I may try to do the bare minimum needed to remove the two Greetings |
|
Hi,
This is follow-up to #541 I forgot to do.
@emollier