Fix SourceLink #62
Merged
Fix SourceLink #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
approved these changes
Feb 28, 2024
|
(I'd like to use this one to check #64 , so I won't merge it yet.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MapSourceRoottarget here is ancient. This all works out of the box now. Verified using https://github.com/Smaug123/nuget-metadata that the source mappings are correct when the GITHUB_ACTION env var is set (we get links like /_//ApiSurface/ApiSurface.fs to https://raw.githubusercontent.com/G-Research/ApiSurface/c1e01a8f03ffe4b0eaae137baf981ae05aa77745//ApiSurface/ApiSurface.fs), and when the env var is not set (i.e. locally, when we get proper links relative to the source files on your actual computer).See https://docs.github.com/en/actions/learn-github-actions/variables for verification that GITHUB_ACTION is set.
Fixes #1 .