Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to centrally-managed actions #84

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Migrate to centrally-managed actions #84

merged 1 commit into from
Aug 28, 2024

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Aug 28, 2024

  1. Bugfix: the all-required-checks-complete action now genuinely does require all checks to succeed (previously it did not).
  2. Feature: we now perform GitHub attestation on the resulting NuGet package. I'll test this once the new version gets released, with gh attestation verify --owner G-Research ~/.nuget/packages/apisurface/{newversion}/apisurface.{newversion}.nupkg.

See https://github.com/G-Research/common-actions

I've tested both these actions under a variety of conditions on my own repos; see, for example, the all-checks-complete and the publish actions.

@Smaug123 Smaug123 marked this pull request as ready for review August 28, 2024 17:26
@Smaug123 Smaug123 requested review from a team as code owners August 28, 2024 17:26
@Smaug123 Smaug123 merged commit f1f1966 into main Aug 28, 2024
13 checks passed
@Smaug123 Smaug123 deleted the migrate-actions branch August 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants