Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] 동화 내용 API 리팩토링 #90

Merged
merged 28 commits into from
Jun 5, 2024
Merged

[refactor] 동화 내용 API 리팩토링 #90

merged 28 commits into from
Jun 5, 2024

Conversation

alsrudrl1220
Copy link
Collaborator

Summary

  • 패키지 구조 정리: bookContent에 controller / service / dto / entity / repository 생성
  • builder 적용 및 setter 삭제, 정리
  • 공통된 DTO -> Request, Response 두 개로 나누어서 정리
  • DTO 수정에 따른 service, controller 수정 반영
  • toEntity 위치를 entity -> dto로 변경

Branch : refactor/#88

alsrudrl1220 added 19 commits May 25, 2024 20:28
@alsrudrl1220
[feat] BookContentEntity Builder 생성자
24fca06
@alsrudrl1220
[feat] 주석으로 원래 toEntity 임시 삭제
bce41af
@alsrudrl1220
[feat] Builder 이용한 toEntity()를 DTO에 추가
fc7dde2
@alsrudrl1220
[fix] Builder 패턴 이용해서 BookContentDTO 생성하는 코드로 수정
a34dd09
@alsrudrl1220
[fix] bookContent package 생성 및 controller 이동
954fb29
@alsrudrl1220
[feat] BookContent에 requestDTO 생성
7f7f410
@alsrudrl1220
[fix] Controller에서 DTO -> Request로 변경
e61efa5
@alsrudrl1220
[fix] requestDTO service에 반영 + 불필요한 코드 간결하게 수정
163e2e3
@alsrudrl1220
[feat] BookContent에 ResponseDTO 생성
c424267
@alsrudrl1220
[fix] Controller에서 List<DTO> -> Response 로 변경
a77fd25
@alsrudrl1220
[fix] responseDTO service에 반영
93628b8
@alsrudrl1220
[fix] entity package 옮기기 + setter 삭제
1190d3b
@alsrudrl1220
[fix] repository package 옮기기
11db4f8
@alsrudrl1220
[fix] service package로 옮기기
d9c3ec2
@alsrudrl1220
[fix] quiz controller에쓰이는 BookContentDTO관련 내용을 response, request로 수정
42df7ea
@alsrudrl1220
[feat] BookContent test code 작성
74acfb5
@alsrudrl1220
[feat] seed data 관련 save()에 주석 추가 - 추후 수정 예정
0b59d85
@alsrudrl1220
[feat] test code then 부분 작성
f4f9d44
@alsrudrl1220
[fix] 필요없는 어노테이션 정리
b28a85f
@RumosZin RumosZin changed the title Refactor/#88 [refactor] 동화 내용 API 리팩토링 May 30, 2024
RumosZin
RumosZin reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@RumosZin RumosZin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 bookContent 폴더를 만들었는데,
project
ㄴ book
ㄴ content
ㄴ info
이런 식으로 패키지 구조를 가져가는 건 어떨까요?

크게 project > [book, info, voca]가 있고, book > [content, quiz, lastpage, feedback, progress] 이렇게요!

@RumosZin RumosZin assigned RumosZin and alsrudrl1220 and unassigned RumosZin May 30, 2024
@alsrudrl1220 alsrudrl1220 merged commit d79049e into GDSC-CAU:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RumosZin RumosZin RumosZin left review comments

Assignees

@alsrudrl1220 alsrudrl1220

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alsrudrl1220 @RumosZin