Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some checks in testMultiFluid are effectively inactive #2876

Closed
paveltomin opened this issue Dec 7, 2023 · 2 comments
Closed

Some checks in testMultiFluid are effectively inactive #2876

paveltomin opened this issue Dec 7, 2023 · 2 comments
Labels
type: new A new issue has been created and requires attention

Comments

@paveltomin
Copy link
Contributor

Some logic mismatch was introduced in
#278
so effectively testNumericalDerivatives check that uses checkRelativeErrorFormat and condition inside:
if (delta > absTol && delta > relTol * value)
is not triggered because default absTol = std::numeric_limits<real64>::max()
Current version of GEOS produces huge diffs that are hidden.
@paveltomin paveltomin added the type: new A new issue has been created and requires attention label Dec 7, 2023
@paveltomin
Copy link
Contributor Author

@dkachuma just FYI

@dkachuma dkachuma mentioned this issue May 23, 2024
Merged
@paveltomin
Copy link
Contributor Author

fixed by #3140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: new A new issue has been created and requires attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paveltomin