-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break up multi fluid test #3140
Conversation
@@ -194,11 +194,13 @@ void CO2BrineFluid< PHASE1, PHASE2, FLASH >::checkTablesParameters( real64 const | |||
template< typename PHASE1, typename PHASE2, typename FLASH > | |||
void CO2BrineFluid< PHASE1, PHASE2, FLASH >::initializePreSubGroups() | |||
{ | |||
#if defined(GEOS_DEVICE_COMPILE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opposite or I am mssing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is supposed to be issued when it's a GPU run. The model is now activated for CPU only runs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3140 +/- ##
===========================================
- Coverage 53.77% 53.74% -0.03%
===========================================
Files 1011 1016 +5
Lines 85816 85756 -60
===========================================
- Hits 46146 46090 -56
+ Misses 39670 39666 -4 ☔ View full report in Codecov by Sentry. |
The fix to the derivative in
|
This PR breaks up the
testMultiFluid
unit test. This test does a full fluid update call and tests the obtained values of fluid properties against expected values. It also does numerical derivative checks at selected fluid conditions (pressure, temperature and composition).This test was getting larger and taking longer to build especially with CUDA. Instead of having all the fluid types in one test, this is now broken up into different tests for the different multiphase fluid types. The common part is factored out into the
MultiFluidTest
test fixture.The numerical derivative tests in this case were not active because a very large absolute tolerance was used (see #2876). These are now activated for most of the fluid types. As a consequence, a fix on the temperature derivative was required in
EzrokhiBrineDensity.hpp
. The tests are not activated for theCompositionalMultiphaseFluidPVTPackage
because this already uses finite differences to calculate derivatives and for some of the test compositions, it is actually unable to give reliable values (the package itself needs updating).The inclusion of
testCompFlowUtils.hpp
inconstitutiveTestHelpers.hpp
was pulling in too many include files into the compilation of thee tests. The methods required for the multiphase fluid tests have now been moved to a smaller includetestFlowUtils.hpp
.This will likely require a rebaseline due to the change in the Ezrokhi density derivative.