Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cubic EOS derivatives #2520

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Implement Cubic EOS derivatives #2520

merged 7 commits into from
Jun 20, 2023

Conversation

dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Jun 9, 2023 •
edited
Loading

  • Adds derivative computation for mixture coefficients and compressibility factor
  • Adds unit tests to compare calculated values with finite difference values

#2465

@dkachuma dkachuma mentioned this pull request Jun 1, 2023
Open
24 tasks
@dkachuma dkachuma marked this pull request as ready for review June 9, 2023 21:25
@dkachuma dkachuma self-assigned this Jun 12, 2023
@dkachuma dkachuma requested a review from francoishamon June 12, 2023 16:48
francoishamon
francoishamon approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@francoishamon francoishamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @dkachuma !

@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs type: feature New feature or request and removed flag: ready for review labels Jun 15, 2023
@francoishamon francoishamon merged commit e251853 into develop Jun 20, 2023
@francoishamon francoishamon deleted the feature/dkachuma/compositional-properties branch June 20, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoishamon francoishamon francoishamon approved these changes

Assignees

@dkachuma dkachuma

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkachuma @francoishamon