-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phase composition to PVTDriver output #2772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/coreComponents/constitutive/fluid/multifluid/PVTDriverRunTest.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/fluid/multifluid/PVTDriverRunTest.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/unitTests/constitutiveTests/testPVT_data/deadOilPVDO.txt
Show resolved
Hide resolved
joshua-white
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Add phase composition to PVTDriver output * Add some doc comments * Split unit tests into separate new file * Change test file name * Reinstate table move to host * Add compressibility flag * Refine doc comment * Some remarks * Remove component molar weight * Fix PVT unit test * Merge branch 'develop' into feature/dkachuma/pvt-driver-extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
flag: ready for review
type: feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the output from the PVTDriver to improve testing of flash functionality.
outputCompressibility
toPVTDriver
to request the total compressibility of the fluid as additional output from the driver.outputPhaseComposition
toPVTDriver
to request the phase compositions as additional outputs from the driver.testPVT_PhaseComposition.xml
by adding extra fluids and activating the flags on some.