Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phase composition to PVTDriver output #2772

Merged
merged 14 commits into from
Nov 9, 2023

Conversation

dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Oct 20, 2023

Extends the output from the PVTDriver to improve testing of flash functionality.

  • Adds a flag outputCompressibility to PVTDriver to request the total compressibility of the fluid as additional output from the driver.
  • Adds a flag outputPhaseComposition to PVTDriver to request the phase compositions as additional outputs from the driver.
  • Adds a new test data in testPVT_PhaseComposition.xml by adding extra fluids and activating the flags on some.

@dkachuma dkachuma self-assigned this Oct 20, 2023
@dkachuma dkachuma added the type: feature New feature or request label Oct 20, 2023
@dkachuma dkachuma mentioned this pull request Oct 20, 2023
24 tasks
@dkachuma dkachuma marked this pull request as ready for review October 20, 2023 04:39
@dkachuma dkachuma marked this pull request as draft October 20, 2023 13:40
@dkachuma dkachuma marked this pull request as ready for review October 20, 2023 14:56
@dkachuma dkachuma requested a review from joshua-white October 20, 2023 15:33
Copy link
Contributor

@joshua-white joshua-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dkachuma dkachuma added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Oct 27, 2023
@castelletto1 castelletto1 merged commit fb7d948 into develop Nov 9, 2023
@castelletto1 castelletto1 deleted the feature/dkachuma/pvt-driver-extension branch November 9, 2023 09:22
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
* Add phase composition to PVTDriver output
* Add some doc comments
* Split unit tests into separate new file
* Change test file name
* Reinstate table move to host
* Add compressibility flag
* Refine doc comment
* Some remarks
* Remove component molar weight
* Fix PVT unit test
* Merge branch 'develop' into feature/dkachuma/pvt-driver-extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants