Use ComponentProperties in calculation functions #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dkachuma/compositional-fluid
paveltomin
reviewed
Nov 10, 2023
| @@ -44,6 +48,8 @@ struct PengRobinsonEOS | |||
| ? 0.37464 + 1.54226 * omega - 0.26992 * omega * omega | |||
| : 0.3796 + 1.485 * omega - 0.164423 * omega * omega + 0.016666 * omega * omega * omega; | |||
| } | |||
|
|
|||
| static constexpr char const * catalogName(){ return "PengRobinson"; } | |||
There was a problem hiding this comment.
I am not sure one needs catalogName for those things, could you help me to understand it here?
There was a problem hiding this comment.
There was a point to this. I believe I have a coupled of commits missing. Let me check my local branch.
There was a problem hiding this comment.
Added one remaining commit. The idea is the negative two phase flash is no longer tied to the cubic eos. So the names are moved into the cubic eos objects themselves. These are used down the line in CompositionalMultiphaseFluid to give names to catalog entries.
paveltomin
reviewed
Nov 10, 2023
...oreComponents/constitutive/fluid/multifluid/compositional/functions/KValueInitialization.hpp
Show resolved
Hide resolved
paveltomin
approved these changes
Nov 10, 2023
paveltomin
reviewed
Nov 10, 2023
src/coreComponents/constitutive/unitTests/testCompositionalProperties.cpp
Show resolved
Hide resolved
paveltomin
approved these changes
Nov 10, 2023
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Create another copy of CompositionalMultiphaseFluid * Create template parameterised Compositional multiphase fluid * Create phase models * Replace template parameter pack with individual parameters * Rename CompositionalMultiphaseFluidPVT to CompositionalMultiphaseFluidPVTPackage * Lump component molecular weight and component names into ComponentProperties * Implement water phase index * Use ComponentProperties ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NegativeTwoPhaseFlashto not be specific to the cubic EOS model.#2465