Cleanup compositional fluid model #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does it fix #2860 ? |
MelReyCG
approved these changes
Dec 4, 2023
Not a problem. Yes, you can have a look at it in the CI. |
Yes it should. |
TotoGaz
added
the
ci: run integrated tests
TotoGaz
added
flag: no rebaseline
|
Hello @dkachuma Can you manage the conflict? Then we can merge your PR 🎉 |
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
- Removes some terrible debugging code - Moves some physical constants to `common/PhysicsConstants.hpp`. - Ensures that the `m_componentNames` private member in `ComponentProperties` is used. - Marks functions in `geos::units as GEOS_HOST_DEVICE`. These are called in some compute kernels causing excessive warnings sometimes (Host-device decorate conversion functions #2860).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common/PhysicsConstants.hpp.m_componentNamesprivate member inComponentPropertiesis used.geos::unitsasGEOS_HOST_DEVICE. These are called in some compute kernels causing excessive warnings sometimes (Host-device decorate conversion functions #2860).