-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link compositional fluid model to static function implementation #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
reviewed
Apr 1, 2024
src/coreComponents/constitutive/fluid/multifluid/MultiFluidConstants.hpp
Show resolved
Hide resolved
paveltomin
reviewed
Apr 1, 2024
...nents/constitutive/fluid/multifluid/compositional/CompositionalMultiphaseFluidPVTPackage.cpp
Show resolved
Hide resolved
Now ready for review. It's quite large but hopefully localised. |
paveltomin
approved these changes
Apr 22, 2024
joshua-white
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. A few minor cleanups have already been noted, but it will be easy to do these in smaller PRs.
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
flag: no rebaseline
Does not require rebaseline
flag: ready for review
type: feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalises the compositional fluid model implementation by linking to static function implementation
multifluid::DerivativeOffset
layout instead of separate variables.CubicEOSPhaseModel
. Adds unit test to numerically test derivatives intestCubicEOS
.NegativeTwoPhaseFlash
. This calculates the derivatives of the calculated vapour fraction and also the liquid and vapour compositions. The idea is that the iterative flash is performed without derivatives and once this converges implicit differentiation is used to calculate the analytical derivatives at the converged solution. Unit tests are added totestNegativeTwoPhaseFlash
to numerically verify the derivatives.PVTDriver
to output the mass density of each phase.constantPhaseViscosity
xml entry for the PVTPackage CompositionalMultiphaseFluid. This allows the user to change the constant viscosity value for each phase.Tasks still outstanding (to be done in follow up PRs)
BlasLapackLA::solveLinearSystem
to GPU.