-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EOS template parameter from compositional fluid model #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' into feature/dkachuma/eos-parameters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3166 +/- ##
========================================
Coverage 55.74% 55.75%
========================================
Files 1038 1041 +3
Lines 88470 88537 +67
========================================
+ Hits 49318 49361 +43
- Misses 39152 39176 +24 ☔ View full report in Codecov by Sentry. |
paveltomin
approved these changes
Jun 27, 2024
Algiane
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Add generic parameters * Fix LBC test * Add EOS parameters to flash --------- Co-authored-by: Pavel Tomin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: ready for review
type: cleanup / refactor
Non-functional change (NFC)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to remove the equation of state template parameter from
CompositonalFluidModel
. The reason for this is to reduce the number of types listed in MultiFluidSelector.hpp. It also simplifies user input.Removing the EOS template parameter from
CompositonalFluidModel
cuts the number of types from 4 to 2. Instead of the EOS being implicitly determined by the object type, there is a user fieldequationsOfState
(similar toCompositonalFluidModelPVTPackage
) which determines the EOS to be used. The downside is that the EOS parameters have to be passed to the compute kernels. The selection is now done withif-else
statements (e.g. FugacityCalculator.hpp).