-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Immiscible water model #3236
Conversation
…s' into feature/dkachuma/eos-parameters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3236 +/- ##
===========================================
+ Coverage 57.51% 57.66% +0.14%
===========================================
Files 1134 1139 +5
Lines 97866 98134 +268
===========================================
+ Hits 56285 56586 +301
+ Misses 41581 41548 -33 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@@ -37,12 +37,14 @@ namespace compositional | |||
enum class EquationOfStateType : integer | |||
{ | |||
PengRobinson, | |||
SoaveRedlichKwong | |||
SoaveRedlichKwong, | |||
ImmiscibleWater |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am probably missing something
a bit confused here - how will it know what eos is to use for hc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is specified in the xml. The phases are "lined up" with the EOS e.g.
<CompositionalThreePhaseFluidLohrenzBrayClark
name="blackOil"
phaseNames="{ oil, gas, water }"
equationsOfState="{ pr, pr, immiscibleWater }" />
However, I think since the immiscibleWater
"EOS" is implied in the element name (CompositionalThreePhaseFluidLohrenzBrayClark
), there is no need to specify this here. I'm inclined to remove it.
move to merge queue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look fine to me.
@rrsettgast please review |
Waiting on code owner review from @CusiniM, @jhuang2601, and/or @rrsettgast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Completes the water on the immiscible water model. This defines a compositional fluid model in which the water component does not participate in the flash but instead makes up it's own 3rd water/aqueous phase which is immiscible with the other 2 phases.
The phase partition is done via
ImmiscibleWaterFlash
. This removes the water component for the negative two phase flash of the "hydrocarbon" phases and reconstitutes the result into 3 phases.The water properties (density and viscosity) are by providing reference values at a reference pressure and temperature and providing a compressibility and a thermal expansion coefficient.