Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plastic/elastic slip fix for EFEM #3348

Merged
merged 64 commits into from
Nov 28, 2024
Merged

Conversation

sohailwaziri
Copy link
Contributor

@sohailwaziri sohailwaziri commented Sep 12, 2024

update/store elastic slip only once at the end of the time step

@paveltomin paveltomin changed the base branch from develop to pt/edfm-sohail-bugfix November 11, 2024 19:58
@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run code coverage enables running of the code coverage CI jobs and removed flag: ready for review labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 57.16%. Comparing base (89a6066) to head (fa0d381).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...omponents/constitutive/contact/CoulombFriction.hpp 0.00% 18 Missing ⚠️
...olvers/contact/SolidMechanicsEmbeddedFractures.cpp 0.00% 13 Missing ⚠️
...reComponents/constitutive/contact/FrictionBase.hpp 0.00% 4 Missing ⚠️
...nents/constitutive/contact/FrictionlessContact.hpp 0.00% 2 Missing ⚠️
...ents/constitutive/contact/RateAndStateFriction.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3348      +/-   ##
===========================================
- Coverage    57.17%   57.16%   -0.02%     
===========================================
  Files         1149     1149              
  Lines        99044    99069      +25     
===========================================
+ Hits         56628    56632       +4     
- Misses       42416    42437      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Nov 26, 2024
@paveltomin paveltomin merged commit a50339b into develop Nov 28, 2024
23 of 25 checks passed
@paveltomin paveltomin deleted the swaziri/experimental branch November 28, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants