-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plastic/elastic slip fix for EFEM #3348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anicsEFEM_impl.hpp
…stick condition. now it gets updated after newton converges
paveltomin
reviewed
Sep 23, 2024
src/coreComponents/physicsSolvers/contact/SolidMechanicsEmbeddedFractures.cpp
Outdated
Show resolved
Hide resolved
… into swaziri/experimental
paveltomin
reviewed
Sep 24, 2024
paveltomin
reviewed
Nov 11, 2024
...hysicsSolvers/multiphysics/poromechanicsKernels/ThermalSinglePhasePoromechanicsEFEM_impl.hpp
Outdated
Show resolved
Hide resolved
paveltomin
removed request for
cssherman,
ryar9534,
frankfeifan and
castelletto1
November 22, 2024 01:46
… into swaziri/experimental
… into swaziri/experimental
CusiniM
approved these changes
Nov 25, 2024
src/coreComponents/physicsSolvers/contact/SolidMechanicsEmbeddedFractures.cpp
Outdated
Show resolved
Hide resolved
…edFractures.cpp Co-authored-by: Matteo Cusini <[email protected]>
paveltomin
added
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run code coverage
enables running of the code coverage CI jobs
and removed
flag: ready for review
labels
Nov 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3348 +/- ##
===========================================
- Coverage 57.17% 57.16% -0.02%
===========================================
Files 1149 1149
Lines 99044 99069 +25
===========================================
+ Hits 56628 56632 +4
- Misses 42416 42437 +21 ☔ View full report in Codecov by Sentry. |
paveltomin
added
the
flag: requires rebaseline
Requires rebaseline branch in integratedTests
label
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run code coverage
enables running of the code coverage CI jobs
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: requires rebaseline
Requires rebaseline branch in integratedTests
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update/store elastic slip only once at the end of the time step