feat: Add functions to connect well perforation to surface elements #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2024 09:17
paveltomin
requested review from
rrsettgast,
CusiniM,
jhuang2601,
castelletto1,
klevzoff,
francoishamon,
matteofrigo5,
wrtobin,
untereiner,
MelReyCG,
corbett5 and
cssherman
as code owners
paveltomin
requested review from
klevzoff,
CusiniM and
tjb-ltk
and removed request for
klevzoff,
wrtobin,
cssherman,
rrsettgast,
untereiner,
francoishamon,
corbett5,
castelletto1,
matteofrigo5,
CusiniM,
jhuang2601 and
MelReyCG
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pt/well-frac #3359 +/- ##
================================================
- Coverage 56.56% 56.23% -0.33%
================================================
Files 1064 1065 +1
Lines 89872 90407 +535
================================================
+ Hits 50832 50840 +8
- Misses 39040 39567 +527 ☔ View full report in Codecov by Sentry. |
|
need review please |
|
need review please |
paveltomin
requested review from
Guotong-Ren
and removed request for
klevzoff
Guotong-Ren
reviewed
Nov 8, 2024
| // remove duplicates | ||
| std::unordered_set< Point3d, PointHash< Point3d >, PointsEqual< Point3d > > | ||
| unique_points( polygon.begin(), polygon.end()); | ||
| polygon.clear(); |
There was a problem hiding this comment.
is degenerated polygon possible here?
paveltomin
added
ci: run integrated tests
paveltomin
removed
the
ci: run integrated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should go after #3227
calculateElementCentersfor subregions earlier intoFaceManager::computeGeometry, so cell centers for surface elements are available when well perforation is processedregisterWrapperforelementCenterandelementVolumeinEmbeddedSurfaceSubRegion, they already registered in the base classgetReservoirElementDimensions/getBoundingBoxto supportSurfaceElementSubRegionSurfaceElementSubRegionversion ofisPointInsideElementand helper functionsisPointInPolygon2d/3d(not super refined implementation but something to start working with)