feat: plastic strain output #3384

ryar9534 · 2024-10-03T09:43:09Z

Introducing a plasticStrain output field in addition to the current total strain. This is done by subtracting the elastic strain (obtained via the getElasticStrain method of the constitutive laws) from the total strain and averaging over quadrature points.

Rebaselining will be required because of the new field.

Ideally, plastic strain would only be output when a plasticity model is being used, but Im not sure how exactly we will do that...

I will run the Drucker-Prager and Modified Cam Clay wellbore problem to test

rrsettgast

Do we want full tensorial plastic strain, or eps?

src/coreComponents/physicsSolvers/solidMechanics/SolidMechanicsLagrangianFEM.cpp

…itial states

rrsettgast

Just thinking that the total and incremental calculations are the same except for the stress inputs. These could be put into a private function so that the calculation is only done in one place.

rrsettgast · 2024-12-16T18:27:16Z

src/coreComponents/constitutive/solid/ElasticIsotropic.hpp

@@ -135,6 +135,11 @@ class ElasticIsotropicUpdates : public SolidBaseUpdates
                                 localIndex const q,
                                 real64 ( &elasticStrain )[6] ) const override final;

+  GEOS_HOST_DEVICE
+  virtual void getElasticStrainInc( localIndex const k,


Suggested change

virtual void getElasticStrainInc( localIndex const k,

virtual void calculateElasticStrainInc( localIndex const k,

Since this isn't really a "getter"

rrsettgast · 2024-12-16T18:27:32Z

src/coreComponents/constitutive/solid/ElasticIsotropic.hpp

@@ -228,6 +233,23 @@ void ElasticIsotropicUpdates::getElasticStrain( localIndex const k,
  elasticStrain[5] = m_newStress[k][q][5] / m_shearModulus[k];
 }

+GEOS_HOST_DEVICE
+inline
+void ElasticIsotropicUpdates::getElasticStrainInc( localIndex const k,


Suggested change

void ElasticIsotropicUpdates::getElasticStrainInc( localIndex const k,

void ElasticIsotropicUpdates::calculateElasticStrainInc( localIndex const k,

rrsettgast · 2024-12-16T18:34:15Z

src/coreComponents/constitutive/solid/ElasticIsotropic.hpp

+  elasticStrainInc[1] = (-nu*(m_newStress[k][q][0] - m_oldStress[k][q][0]) +    (m_newStress[k][q][1] - m_oldStress[k][q][1]) - nu*(m_newStress[k][q][2] - m_oldStress[k][q][2]))/E;
+  elasticStrainInc[2] = (-nu*(m_newStress[k][q][0] - m_oldStress[k][q][0]) - nu*(m_newStress[k][q][1] - m_oldStress[k][q][1]) +    (m_newStress[k][q][2] - m_oldStress[k][q][2]))/E;
+
+  elasticStrainInc[3] = (m_newStress[k][q][3] - m_oldStress[k][q][3]) / m_shearModulus[k];


was this question resolved? ChatGPT says paraview expects tensorial strain...but I think it came to that conclusion because it calculates tensorial strain.

ryar9534 · 2024-12-16T19:13:17Z

was this question resolved? ChatGPT says paraview expects tensorial strain...but I think it came to that conclusion because it calculates tensorial strain.

To me, it seems like it would be weird if paraview did operations to a tensor field, as IDK how it would know to do it for strain and not everything else. Thoughts @CusiniM ? I thought we were just gonna merge it

paveltomin · 2025-01-07T18:10:42Z

can someone check if new baselines are ok?
i see things like that:

Error: /Problem/domain/MeshBodies/mesh1/meshLevels/Level0/ElementRegions/elementRegionsGroup/Domain/elementSubRegions/cb1/strain
	Arrays of types float64 and float64 have 378 values of which 63 fail both the relative and absolute tests.
		Max absolute difference is at index (np.int64(30), np.int64(5)): value = 7.644588483567542e-05, base_value = 0.00015289176967135085
		Max relative difference is at index (np.int64(30), np.int64(5)): value = 7.644588483567542e-05, base_value = 0.00015289176967135085
	Statistics of the q values greater than 1.0 defined by absolute tolerance: N = 63
		max = 7644.588483567542, mean = 124.862153686749, std = 711.8661761259043
		max is at index (np.int64(30), np.int64(5)), value = 7.644588483567542e-05, base_value = 0.00015289176967135085
	Statistics of the q values greater than 1.0 defined by relative tolerance: N = 0

is it because plastic part is separate now?

jhuang2601 · 2025-01-07T18:20:15Z

can someone check if new baselines are ok? i see things like that:

Error: /Problem/domain/MeshBodies/mesh1/meshLevels/Level0/ElementRegions/elementRegionsGroup/Domain/elementSubRegions/cb1/strain
	Arrays of types float64 and float64 have 378 values of which 63 fail both the relative and absolute tests.
		Max absolute difference is at index (np.int64(30), np.int64(5)): value = 7.644588483567542e-05, base_value = 0.00015289176967135085
		Max relative difference is at index (np.int64(30), np.int64(5)): value = 7.644588483567542e-05, base_value = 0.00015289176967135085
	Statistics of the q values greater than 1.0 defined by absolute tolerance: N = 63
		max = 7644.588483567542, mean = 124.862153686749, std = 711.8661761259043
		max is at index (np.int64(30), np.int64(5)), value = 7.644588483567542e-05, base_value = 0.00015289176967135085
	Statistics of the q values greater than 1.0 defined by relative tolerance: N = 0

is it because plastic part is separate now?

Which case are you referring to? Plastic strain is registered as a new field (root cause for the failure) and the total strain is not touched in this PR.

paveltomin · 2025-01-07T18:23:25Z

is it because plastic part is separate now?

Which case are you referring to? Plastic strain is registered as a new field (root cause for the failure) and the total strain is not touched in this PR.

for example this

ryar9534 · 2025-01-07T18:40:32Z

I did touch the total strain in this pr. We decided to divide the shear by 2 following discussions about engineering vs tensor strain. Hence the new baselines.

joshua-white · 2025-01-07T18:55:20Z

I did touch the total strain in this pr. We decided to divide the shear by 2 following discussions about engineering vs tensor strain. Hence the new baselines.

A large number of functions in the plasticity routine were written assuming engineering strains. I would definitely double check none of the physical results have changed before rebaselining anything. Would be very easy to make a mistake here. The error posted above has a factor of 2x in it, though, so that's encouraging.

ryar9534 · 2025-01-07T19:23:17Z

Yes, all the computations seem to be done in engineering strain. @CusiniM and I decided to convert to tensor strain just for output.

jhuang2601 · 2025-01-07T21:42:00Z

Yes, all the computations seem to be done in engineering strain. @CusiniM and I decided to convert to tensor strain just for output.

That sounds good. Let me rerun the tutorial plastic example with strain hardening to confirm it.

jhuang2601 · 2025-01-07T22:14:28Z

I did touch the total strain in this pr. We decided to divide the shear by 2 following discussions about engineering vs tensor strain. Hence the new baselines.

A large number of functions in the plasticity routine were written assuming engineering strains. I would definitely double check none of the physical results have changed before rebaselining anything. Would be very easy to make a mistake here. The error posted above has a factor of 2x in it, though, so that's encouraging.

I can reproduce this tutorial example with the PR, which confirms that correct engineering strains are utilized by the Extended Drucker-Prager Model.

ryar9534 added 2 commits October 3, 2024 11:08

Update SolidMechanicsLagrangianFEM.cpp

d5de7f3

Update StrainHelper.hpp

662836f

ryar9534 self-assigned this Oct 3, 2024

ryar9534 added 4 commits October 3, 2024 12:19

Update SolidMechanicsFields.hpp

df505c2

Update SolidMechanicsLagrangianFEM.cpp

3b0bd7b

Update StrainHelper.hpp

78e4db4

Update StrainHelper.hpp

a23f26f

ryar9534 marked this pull request as ready for review October 3, 2024 11:46

ryar9534 requested review from rrsettgast, castelletto1 and CusiniM as code owners October 3, 2024 11:46

ryar9534 added 3 commits October 3, 2024 13:51

Update StrainHelper.hpp

c2325c3

Update StrainHelper.hpp

27a4801

Update StrainHelper.hpp

18a94b2

ryar9534 linked an issue Oct 3, 2024 that may be closed by this pull request

Elastic/Plastic strain outputs in GEOS #3210

Closed

ryar9534 added 9 commits October 3, 2024 14:22

Update SolidMechanicsLagrangianFEM.cpp

c7e03b9

Update SolidMechanicsLagrangianFEM.cpp

2f4e691

Update StrainHelper.hpp

3cf18ca

Update SolidMechanicsLagrangianFEM.cpp

4284d71

Update SolidMechanicsLagrangianFEM.cpp

cd42322

Update SolidMechanicsLagrangianFEM.cpp

6700051

Update SolidMechanicsLagrangianFEM.cpp

5c8f164

Update StrainHelper.hpp

7a51c30

Update StrainHelper.hpp

ca89c99

ryar9534 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Oct 3, 2024

ryar9534 added 2 commits October 3, 2024 16:30

Merge branch 'develop' into feature/aronson/plasticStrainOutput

0e72772

Merge branch 'develop' into feature/aronson/plasticStrainOutput

4f21e46

rrsettgast approved these changes Oct 8, 2024

View reviewed changes

src/coreComponents/physicsSolvers/solidMechanics/SolidMechanicsLagrangianFEM.cpp Outdated Show resolved Hide resolved

ryar9534 added 2 commits October 11, 2024 15:30

initial implementation, behavior is almost right but need to debug in…

cf6fe98

…itial states

remove extraneous file

8fda259

ryar9534 added 4 commits December 13, 2024 14:46

Add elastic strain functions to ElasticTransverseIsotropic

d403991

Update .integrated_tests.yaml

b04133d

uncrustify

d8a1680

Merge branch 'develop' into feature/aronson/plasticStrainOutput

bb8efc1

rrsettgast reviewed Dec 16, 2024

View reviewed changes

ryar9534 and others added 12 commits December 16, 2024 12:12

Update .integrated_tests.yaml

01cce1e

Merge branch 'develop' into feature/aronson/plasticStrainOutput

cfe31b2

Update .integrated_tests.yaml

caef37b

restructure elasticIsotropic

69ade8d

restructure elasticOrthotropic

576e7bb

restructure elasticTransverseIsotropic

54f91fc

uncrustify

93b5268

Update StrainHelper.hpp to output tensor strain not engineering

592b991

Merge branch 'develop' into feature/aronson/plasticStrainOutput

381d6ba

Update .integrated_tests.yaml

2c13f68

Merge branch 'develop' into feature/aronson/plasticStrainOutput

74c7226

Merge branch 'develop' into feature/aronson/plasticStrainOutput

4e0f693

Update .integrated_tests.yaml

0ce3b32

jhuang2601 approved these changes Jan 7, 2025

View reviewed changes

paveltomin merged commit a8a57c7 into develop Jan 7, 2025
23 of 25 checks passed

paveltomin deleted the feature/aronson/plasticStrainOutput branch January 7, 2025 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: plastic strain output #3384

feat: plastic strain output #3384

ryar9534 commented Oct 3, 2024 •

edited

Loading

rrsettgast left a comment

rrsettgast left a comment

rrsettgast Dec 16, 2024

rrsettgast Dec 16, 2024

rrsettgast Dec 16, 2024

ryar9534 commented Dec 16, 2024

paveltomin commented Jan 7, 2025

jhuang2601 commented Jan 7, 2025

paveltomin commented Jan 7, 2025

ryar9534 commented Jan 7, 2025

joshua-white commented Jan 7, 2025

ryar9534 commented Jan 7, 2025

jhuang2601 commented Jan 7, 2025

jhuang2601 commented Jan 7, 2025

	virtual void getElasticStrainInc( localIndex const k,
	virtual void calculateElasticStrainInc( localIndex const k,

	void ElasticIsotropicUpdates::getElasticStrainInc( localIndex const k,
	void ElasticIsotropicUpdates::calculateElasticStrainInc( localIndex const k,

feat: plastic strain output #3384

feat: plastic strain output #3384

Conversation

ryar9534 commented Oct 3, 2024 • edited Loading

rrsettgast left a comment

Choose a reason for hiding this comment

rrsettgast left a comment

Choose a reason for hiding this comment

rrsettgast Dec 16, 2024

Choose a reason for hiding this comment

rrsettgast Dec 16, 2024

Choose a reason for hiding this comment

rrsettgast Dec 16, 2024

Choose a reason for hiding this comment

ryar9534 commented Dec 16, 2024

paveltomin commented Jan 7, 2025

jhuang2601 commented Jan 7, 2025

paveltomin commented Jan 7, 2025

ryar9534 commented Jan 7, 2025

joshua-white commented Jan 7, 2025

ryar9534 commented Jan 7, 2025

jhuang2601 commented Jan 7, 2025

jhuang2601 commented Jan 7, 2025

ryar9534 commented Oct 3, 2024 •

edited

Loading