Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QD rate and state friction coupled with Mechanics and Poromechanics solvers. #3416

Merged
merged 132 commits into from
Jan 22, 2025

Conversation

CusiniM
Copy link
Collaborator

@CusiniM CusiniM commented Oct 28, 2024

In this PR:

  • Refactoring of QD solvers
    • introduced a base class for implicit and explicit integrators
    • introduced dedicated variables for shear and normal tractions and for background stresses.
    • added coupling with any geos solver (provided that it knows how to compute tractions)
  • Introduced a OneWayCoupled solver to solve for flow in the fracture and mechanics around it separately. It could probably be done through a Poromechanics solver but I don't think we really want this option to persist. It is just needed to run one of the SCEC benchmarks.
  • Add SCEC-BP6 benchmark input files.

Copy link
Contributor

@matteofrigo5 matteofrigo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add brief descriptions for the functions that are missing in the Doxygen documentation

@CusiniM CusiniM added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jan 10, 2025
@CusiniM CusiniM added ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jan 17, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 1.22200% with 485 lines in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (17053bb) to head (1355f13).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...csSolvers/inducedSeismicity/QDRateAndStateBase.cpp 0.00% 120 Missing ⚠️
...Seismicity/kernels/ImplicitRateAndStateKernels.hpp 0.00% 78 Missing ⚠️
...lvers/inducedSeismicity/ImplicitQDRateAndState.cpp 0.00% 61 Missing ⚠️
.../physicsSolvers/inducedSeismicity/SpringSlider.cpp 0.00% 53 Missing ⚠️
...lvers/inducedSeismicity/QuasiDynamicEarthQuake.cpp 0.00% 40 Missing ⚠️
...ucedSeismicity/kernels/RateAndStateKernelsBase.hpp 0.00% 39 Missing ⚠️
...lvers/inducedSeismicity/ExplicitQDRateAndState.cpp 0.00% 27 Missing ⚠️
...sics/OneWayCoupledFractureFlowContactMechanics.cpp 0.00% 19 Missing ⚠️
...Seismicity/kernels/ExplicitRateAndStateKernels.hpp 0.00% 15 Missing ⚠️
...nents/physicsSolvers/contact/ContactSolverBase.cpp 0.00% 8 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3416      +/-   ##
===========================================
- Coverage    56.85%   56.79%   -0.07%     
===========================================
  Files         1158     1168      +10     
  Lines       101273   101395     +122     
===========================================
+ Hits         57582    57586       +4     
- Misses       43691    43809     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CusiniM CusiniM requested a review from cssherman as a code owner January 22, 2025 00:41
@CusiniM CusiniM merged commit 50504b5 into develop Jan 22, 2025
23 of 25 checks passed
@CusiniM CusiniM deleted the feature/quasiDynamic-rs-mechanicsCoupling branch January 22, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants