-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make new gravity treatment from #3337 an option #3467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don' t know that we really need 2 options for the treatment of gravity. In general, I think that what @paveltomin had introduced made more sense... I am not too sure why it would have such a large impact on convergence. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3467 +/- ##
===========================================
- Coverage 57.11% 57.11% -0.01%
===========================================
Files 1151 1151
Lines 99454 99475 +21
===========================================
+ Hits 56808 56818 +10
- Misses 42646 42657 +11 ☔ View full report in Codecov by Sentry. |
@paveltomin The term |
Ok will do |
is this #3486 better? |
disabled by default since SPE11 case degradations were observed