Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clarify new gravity, clean up kernel flags usage, move CFL computations to FVM solver #3486

Merged
merged 14 commits into from
Jan 7, 2025

Update .integrated_tests.yaml

4cf2b6e
Select commit
Loading
Failed to load commit list.
Merged

refactor: clarify new gravity, clean up kernel flags usage, move CFL computations to FVM solver #3486

Update .integrated_tests.yaml
4cf2b6e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 7, 2025 in 0s

56.83% (+0.01%) compared to b3592de

View this Pull Request on Codecov

56.83% (+0.01%) compared to b3592de

Details

Codecov Report

Attention: Patch coverage is 29.89130% with 129 lines in your changes missing coverage. Please review.

Project coverage is 56.83%. Comparing base (b3592de) to head (4cf2b6e).

Files with missing lines Patch % Lines
...csSolvers/fluidFlow/CompositionalMultiphaseFVM.cpp 23.13% 103 Missing ⚠️
...sSolvers/fluidFlow/CompositionalMultiphaseBase.hpp 0.00% 5 Missing ⚠️
...s/fluidFlow/kernels/compositional/IHUPhaseFlux.hpp 0.00% 4 Missing ⚠️
...vers/fluidFlow/kernels/compositional/CFLKernel.cpp 0.00% 3 Missing ⚠️
...ysics/CompositionalMultiphaseReservoirAndWells.cpp 0.00% 3 Missing ⚠️
...ositional/DiffusionDispersionFluxComputeKernel.hpp 0.00% 2 Missing ⚠️
...idFlow/kernels/compositional/FluxComputeKernel.hpp 50.00% 2 Missing ⚠️
...al/ThermalDiffusionDispersionFluxComputeKernel.hpp 0.00% 2 Missing ⚠️
...rs/multiphysics/CoupledReservoirAndWellKernels.hpp 0.00% 2 Missing ⚠️
...sSolvers/fluidFlow/CompositionalMultiphaseBase.cpp 83.33% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3486      +/-   ##
===========================================
+ Coverage    56.82%   56.83%   +0.01%     
===========================================
  Files         1154     1154              
  Lines        99983    99954      -29     
===========================================
- Hits         56818    56812       -6     
+ Misses       43165    43142      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov