Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack-Stack 1.7.0 and Discover SLES15 Modules #32

Merged
merged 7 commits into from
Apr 8, 2024

Conversation

Dooruk
Copy link
Collaborator

@Dooruk Dooruk commented Mar 13, 2024

Including SLES15 platform and updating to spack-stack 1.7.0 modules.

Also changes the gsibec version

@Dooruk Dooruk linked an issue Mar 13, 2024 that may be closed by this pull request
@Dooruk Dooruk changed the title Discover SLES15 Modules Spack-Stack 1.7.0 and Discover SLES15 Modules Apr 2, 2024
@Dooruk Dooruk marked this pull request as ready for review April 2, 2024 18:01
@gmao-jjin3
Copy link
Collaborator

@Dooruk I cannot checkout your branch "feature/discover_sles15". Strange.

@gmao-jjin3
Copy link
Collaborator

@Dooruk I cannot checkout your branch "feature/discover_sles15". Strange.

My bad. I didn't see that it was in "jedi-bundle".

@gmao-jjin3 gmao-jjin3 removed their request for review April 2, 2024 18:34
Copy link
Collaborator

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Apologies if I broke the platform lookup thing for Disco.

@Dooruk
Copy link
Collaborator Author

Dooruk commented Apr 2, 2024

Looks reasonable. Apologies if I broke the platform lookup thing for Disco.

It was failing while discerning between the two Discover OS.

JEDI builds with the SLES12 Intel modules but pip install is giving Illegal instruction error. I will ask Dom, I didn't get this error with SLES15 previously.

@mathomp4 could this be because we are trying to implement a unified spack environment on two different OS's?

@mathomp4
Copy link
Member

mathomp4 commented Apr 2, 2024

Illegal instruction? Hmm. Well, you can get that if something compiled in a flag not supported on a chipset (say an Intel-only instruction that AMD chips have).

But often that's just a catch all for "things crashed".

Can you reproduce the crash on the commandline?

@Dooruk
Copy link
Collaborator Author

Dooruk commented Apr 4, 2024

Illegal instruction? Hmm. Well, you can get that if something compiled in a flag not supported on a chipset (say an Intel-only instruction that AMD chips have).

Dom switched the intel compiler to 2021.6.0 and now all is good. I need to make the necessary updates now...

Potential explanation by Dom:

It is a combination of switching from zlib to zlib-ng AND using [email protected] AND being on a particular system. We are only seeing this on Discover SLES12 and S4, and the problems go away when using an older 2021.3.0, 2021.4.0 or newer 2021.6.0+ version of the compiler. On other systems that use 2021.5.0 (e.g. the navy nautilus machine, which is penguin linux), we don’t see the issue.

Bonus:
Screenshot 2024-04-04 at 10 16 49 AM

@Dooruk Dooruk merged commit 02fb82f into develop Apr 8, 2024
3 checks passed
@Dooruk Dooruk deleted the feature/discover_sles15 branch April 8, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Discover SCU17 as a new platform
4 participants