-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-defined "pinned versions" for JEDI repos #38
Conversation
TODO add github actions test for pinned version case |
Hi @asewnath , just saw this but I didn't receive any notifications. Is it ready for testing? |
…/jedi_bundle into feature/pinned_versions
…/jedi_bundle into feature/pinned_versions
…/jedi_bundle into feature/pinned_versions
Co-authored-by: Alexey Shiklomanov <[email protected]>
…/jedi_bundle into feature/pinned_versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure import typing
is not necessary to enable type hinting, so I recommend removing it (from git.py
). The hints are ignored by the runtime anyway, so it doesn't really do anything. I think you mostly import typing
for specific functions or classes -- e.g., from typing import Union
.
Otherwise, this is good to go. Nice work! This will be a really useful change to making SWELL work more reliably and giving us more control over our integration with JEDI.
Ah okay good to know! I thought |
Description
Adding ability for an optional pinned version config file to override defaults in
jedi_bundle
.Example pinned version config file:
New config field
commit
is introduced to specify if the given branch is a hash. This follows the yaml configuration style injedi_bundle
's default configs. Note that the pinned version config file can also handle branches and tags.Pinned version config file is saved in
jedi_bundle
and can be invoked with these flags:jedi_bundle --pinned_versions
jedi_bundle -pv
Contents of the pinned versions config file is added to build.yaml. Then, the
Clone
task proceeds as normal with the build.yaml file.See issue for more information: GEOS-ESM/swell#345