Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to latest FMS update and have an option to install DA-utils #41

Merged
merged 10 commits into from
Jul 31, 2024

Conversation

Dooruk
Copy link
Collaborator

@Dooruk Dooruk commented Jul 16, 2024

This is taking care of multiple JEDI updates/issues:

  1. Use FMS/2023.04 as a module #44

With this update, there is no need to copy mom6 and fv3 repos for soca and fv3-jedi builds anymore. These modules are linked via CMake instead.

Waiting on this https://github.com/JCSDA-internal/jedi-bundle/pull/103 to be merged first. merged

Second, this line is required in CMakelists.txt

list( APPEND CMAKE_INSTALL_RPATH ${CMAKE_CURRENT_BINARY_DIR}/fv3 )

Similar module updates will be done in SWELL for build method to work @asewnath GEOS-ESM/swell#395

  1. add DA-utils as an optional repo #43

Now it is possible to build NOAA-EMC's DA-utils as an optional package (uses IODA and OOPS modules). It's a shared repo so we could contribute.

For this to be built, da-utils needs to be added in extra_repos and NOAA-EMC needs to be added to the github_orgs list in build.yaml.

  1. saber depends on vader #45
    Build order change, saber depends on vader so vader gets built first: https://github.com/orgs/JCSDA-internal/discussions/143

  2. pycodestyle version should be less than 2.12 #42

Some of this could use a documentation update...

@Dooruk Dooruk added Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs enhancement New feature or request labels Jul 22, 2024
This was linked to issues Jul 22, 2024
@Dooruk Dooruk self-assigned this Jul 22, 2024
@Dooruk Dooruk marked this pull request as ready for review July 22, 2024 15:39
@asewnath
Copy link
Collaborator

This is taking care of multiple JEDI updates/issues:

⚠️ one minor issue left, @asewnath when I run jedi_bundle I receive empty strings in the repo section of build.yaml, not sure if that is related to the pinned versions update?

I'm not sure what you mean by the repo section. Do you mean bundles? The pinned versions update had no changes to the default build.yaml other than appending the additional pinned_versions dictionary at the end. Can you post what the build.yaml looks like?

@Dooruk
Copy link
Collaborator Author

Dooruk commented Jul 22, 2024

I had to add cloning a single file from a repo method, otherwise whenever any repo containing CMakelists.txt gets cloned, such as jedi-bundle, ecbuild tries to build it, rightfully so!

@asewnath
Copy link
Collaborator

I installed your branch and the build.yaml file I have after running jedi_bundle doesn't have the empty string issue. Was there something else I needed to do to recreate the empty string issue you're seeing?

@Dooruk
Copy link
Collaborator Author

Dooruk commented Jul 22, 2024

I installed your branch and the build.yaml file I have after running jedi_bundle doesn't have the empty string issue. Was there something else I needed to do to recreate the empty string issue you're seeing?

Hmm, I'm testing it on SLES15. Let me install it on SLES12 and see.

@Dooruk
Copy link
Collaborator Author

Dooruk commented Jul 22, 2024

I installed your branch and the build.yaml file I have after running jedi_bundle doesn't have the empty string issue. Was there something else I needed to do to recreate the empty string issue you're seeing?

You are right, reinstalled the repo and not receiving that bug anymore. Wish every solution was that simple!

So this is ready for testing/review, as long as the fv3-interface.cmake change is made after the cloning phase until the jedi-bundle PR is merged.

@Dooruk Dooruk removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jul 30, 2024
@Dooruk Dooruk merged commit 6d2a93d into develop Jul 31, 2024
7 checks passed
@Dooruk Dooruk deleted the feature/fmsupdate_and_dautils branch August 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants