Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swell couldn't handle missing observation data files during fetching. #459

Open
gmao-wgu opened this issue Nov 20, 2024 · 2 comments
Open
Assignees

Comments

@gmao-wgu
Copy link
Contributor

I purposely removed the IASI Metop-B and Metop-C observation data files from the R2D2 location, and it crashed during fetching. The error message in the job.err file within the GetObservations-geos_atmosphere directory is as follows:

File "/discover/nobackup/projects/gmao/advda/JediOpt/core/r2d2/sles12_skylab7/lib/python3.10/site-packages/r2d2/queries/fetch.py", line 23, in action
database.fetch_data(source, target, request, archive_side_request)
File "/discover/nobackup/projects/gmao/advda/JediOpt/core/r2d2/sles12_skylab7/lib/python3.10/site-packages/r2d2/database/db_manager.py", line 87, in fetch_data raise FileNotFoundError(f'Could not find {source} in {" or ".join(self.fetch_order)}')
FileNotFoundError: Could not find ncdiag.x0048v2.ob.PT6H.iasi_metop-b.2021-12-11T21:00:00Z.nc4 in wgu or gmao-shared
2024-11-20T16:51:24Z CRITICAL - failed/ERR

@Dooruk
Copy link
Collaborator

Dooruk commented Nov 21, 2024

Missing files handling has multiple steps: 1) r2d2 fetch should ignore missing obs, 2) get_observations.py task should handle missing observations as it serves multiple purposes beyond fetching obs such as combining obs if needed, varBC, and aircraftBC cycling. Hence, this multi-purpose design requires careful modification, 3) UFO filters (which there are multiple PRs in SWELL currently)

I'm working on number 1 (this one is handled) and 2 (it broke atmosphere side) in the following PR as ODAS has lot of missing obs (due to temporal data sparsity):

#444

FYI @rtodling @mranst @ashiklom for visibility

@gmao-wgu
Copy link
Contributor Author

@Dooruk While working on number 1, is it possible for a zero-length NC4 file to be created if an observation file is missing? this zero-length file could then be fetched and tested in UFO filters.

@Dooruk Dooruk self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants