-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing GMAO ODAS obs sources #444
Conversation
Quite nice!!! |
I'm getting a |
Hmm, can you check your |
There is |
Derived variables one is the GeoVals, and |
Ok, on a second look, that GeoVal ( |
OK, after commenting out those lines and changing the analysis variable names in the override yaml, it seems to be working fine. |
Added currently available ODAS observations to SWELL. Reminder that in the long term
geos_ocean
will go away and I will take out inactive obs. YAMLs. SOCA naming sprint changes are included.Important changes:
Two changes regarding
get_observations.py
that are important to emphasize (FYI @rtodling @gmao-wgu @mranst @ashiklom ):R2D2
fetch
method now includes aignore missing: True
flag, so it just creates a warning if the observation file is missing. This is necessary because we want Variational Bias Coeff.s to propagate regardless of the missing obs. This will need further testing by ADAS (@rtodling)Since there could be multiple providers for observations (
odas
andgdas_marine
(EMC) for marine) I switchedobs_provider
key to be a check-list soget_observations.py
can browse multiple locations. There could be better handling of this in the future with R2D2v3 but this is where we are for now.Some Quick Plots:
Showing scatter plots for ARGO data jedi vs h(x) salinity and temperature (black dots failed the QC).
FYI @DavidSRussell, you should be able to test with these YAMLs (by setting
odas
as the obs provider) and in theory it should be easy to add SWOT altimeter data to the list.