Correct near surface wind scaling #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danholdaway
changed the title
danholdaway
requested review from
asewnath,
gmao-msienkie,
gmao-wgu and
gmao-jjin3
…/GEOS-ESM/swell into feature/fix_surface_wind_scaling
gmao-jjin3
approved these changes
Sep 27, 2023
src/swell/configuration/jedi/interfaces/geos_atmosphere/observations/sfcship.yaml
Show resolved
Hide resolved
src/swell/configuration/jedi/interfaces/geos_atmosphere/observations/sfc.yaml
Show resolved
Hide resolved
src/swell/configuration/jedi/interfaces/geos_atmosphere/observations/scatwind.yaml
Show resolved
Hide resolved
|
I'm going to merge this but acknowledge that we should covert surface types to geometric height instead of geopotential height. The tests all look good so I think it's OK for now. We need the PRs in fv3-jedi to be able to provide geometric height. I believe Emily was going to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add support for computing the near surface wind scaling variable correctly using the changes in UFO
Dependencies
Impact
N/A