Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move observational error assignments into 'obs prior filters'. #258

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

gmao-jjin3
Copy link
Contributor

@gmao-jjin3 gmao-jjin3 commented Oct 6, 2023

Description

Solve the issue #254 that radiance benchmark counts changed after https://github.com/JCSDA-internal/ufo/pull/3041 was merged into the UFO develop branch. "obs prior filters" and "obs post fiters" have to be configured properly, or the filter to check channels' "use_flag" messes up with the new develop branch. This PR moves observational error assignments into "obs prior filters" and adds "obs post filters".

@gmao-jjin3 gmao-jjin3 changed the title Move observational error assignment in to 'obs prior filters'. Set observational error assignments into 'obs prior filters'. Oct 7, 2023
@gmao-jjin3 gmao-jjin3 changed the title Set observational error assignments into 'obs prior filters'. Move observational error assignments into 'obs prior filters'. Oct 7, 2023
Copy link
Contributor

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around on the fix @gmao-jjin3

@danholdaway danholdaway merged commit 88fea03 into develop Oct 10, 2023
@danholdaway danholdaway deleted the feature/jjin3/obs_prior_filter_oberr branch October 10, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants