Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Yaml linting action #271

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Remove the Yaml linting action #271

merged 2 commits into from
Oct 27, 2023

Conversation

danholdaway
Copy link
Contributor

Description

Removing the YAML linting action

  • Many YAMLs need to have Jinja2 templating and according to the developer of yamllint these kinds of files are not YAMLs and therefore cannot be linted.
  • It is questionable that the linting actually enforces much of a consistent sytle.

@danholdaway danholdaway requested a review from asewnath October 25, 2023 15:27
@danholdaway danholdaway marked this pull request as ready for review October 25, 2023 15:27
@danholdaway danholdaway requested a review from jardizzo as a code owner October 25, 2023 15:27
@asewnath
Copy link
Collaborator

On my github this looks like it's been stuck on the yaml coding norms for two days. Is that the case for anyone else? Just wondering if my github is glitching

@danholdaway
Copy link
Contributor Author

On my github this looks like it's been stuck on the yaml coding norms for two days. Is that the case for anyone else? Just wondering if my github is glitching

After the merge I will delete that check from GitHub,

@danholdaway danholdaway merged commit 60d99fd into develop Oct 27, 2023
2 checks passed
@danholdaway danholdaway deleted the feature/remove_yaml_lint branch October 27, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asewnath asewnath asewnath approved these changes

@jardizzo jardizzo Awaiting requested review from jardizzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danholdaway @asewnath