Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jedi var bc sprint update #338

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

gmao-jjin3
Copy link
Contributor

@gmao-jjin3 gmao-jjin3 commented May 8, 2024

Description

Updated atmospheric observational configurations and the script to create new satellite and aircraft bias correction coefficient files. All tests in swell-ufo_testing pass when geoval files are generated on-the-fly.

Note: All archived satbias and geoval files need to be re-generated by SWELL, or tests in other Swell test suites fail because of those files are out of date once the JEDI team merge updates made within VarBC-sprint.

Dependencies on JEDI various feature/VarBC-sprint PRs in UFO, IODA, and IODACONV

Impact:
Other Swell test suits need new satbias, and likely new geoval, files.

Copy link
Contributor

@gmao-yzhu gmao-yzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in yaml files, module and .py file look fine to me. Thanks for the quick action!

@Dooruk
Copy link
Collaborator

Dooruk commented May 13, 2024

I only had to update the satbias files, geovals are up-to-date already. Tier 1 tests pass with the new JEDI version and this branch.

@rtodling FYI, files in R2D2/Shared/gsi/bc are updated, might break some of your workflows.

@Dooruk Dooruk merged commit 5358cb4 into develop May 13, 2024
21 of 22 checks passed
@Dooruk Dooruk deleted the feature/jedi_VarBC-sprint_update branch May 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants