Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soca increment plots using eva #346

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Soca increment plots using eva #346

merged 3 commits into from
Jun 5, 2024

Conversation

asewnath
Copy link
Contributor

@asewnath asewnath commented May 23, 2024 •
edited
Loading

Description

Adding ability to produce increment plots for SOCA in 3dvar suite. Since the eva config file is purely an example, I'd expect that it would be updated to include more diagnostics before this PR is merged.

Resolves #342

Dooruk
Dooruk reviewed May 24, 2024
View reviewed changes
Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asewnath, thanks again for working on this.

I have a branch with the CICE6 sea-ice analysis and that will require a few more additional steps to this, regarding map domain. I can merge this to that branch and work on the comments I just made to this PR, or we can just merge this one first if you want to fix the code. Let me know.

src/swell/suites/3dvar/eva/increment-geos_ocean.yaml Outdated Show resolved Hide resolved
src/swell/suites/3dvar/eva/increment-geos_ocean.yaml Outdated Show resolved Hide resolved
src/swell/suites/3dvar/eva/increment-geos_ocean.yaml Outdated Show resolved Hide resolved
src/swell/suites/3dvar/eva/increment-geos_ocean.yaml Outdated Show resolved Hide resolved
src/swell/suites/3dvar/eva/increment-geos_ocean.yaml Outdated Show resolved Hide resolved
src/swell/suites/3dvar/eva/increment-geos_ocean.yaml Outdated Show resolved Hide resolved
src/swell/suites/3dvar/eva/increment-geos_ocean.yaml Outdated Show resolved Hide resolved
@asewnath
Copy link
Contributor Author

@asewnath, thanks again for working on this.

I have a branch with the CICE6 sea-ice analysis and that will require a few more additional steps to this, regarding map domain. I can merge this to that branch and work on the comments I just made to this PR, or we can just merge this one first if you want to fix the code. Let me know.

Please feel free to make the config yaml changes yourself

@Dooruk Dooruk self-requested a review June 5, 2024 16:28
Dooruk
Dooruk approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good!

@Dooruk Dooruk merged commit beb1452 into develop Jun 5, 2024
2 checks passed
@Dooruk Dooruk deleted the feature/soca_inc branch June 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dooruk Dooruk Dooruk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Produce SOCA increment plots using EVA
2 participants
@asewnath @Dooruk