-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards WCDA: Introduce geos_marine
, keep geos_ocean
#370
Conversation
geos_marine
, keep geos_ocean
geos_marine
, keep geos_ocean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few minor comments on the Python implementation, but I'm not equipped (yet) to comment on the YAML configs that are the bulk of this PR or the science behind them. I'll have to defer to somebody with a better understanding of JEDI for that.
Thanks for reviewing this PR. I'm the only one exercising the cyling GEOS+SOCA capability currently so I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments related to a bug found when building swell experiments with the CLI
I am going to merge this to move forward with the FMS updates. |
This introduces
geos_marine
as a 3rd model interface and allows assimilating ocean and sea-ice data (first proper Weakly-Coupled DA with SWELL!).geos_marine
will eventually replacegeos_ocean
but we can keep it around for now while we figure out ocean-only DA vs. marine DA changes. So that creates a lot of code duplication in terms of observation YAMLs undergeos_ocean
andgeos_marine
but that is temporary.Some highlights:
run_geos_executable
as we point to the external GEOS builds and experiment directories.flow.cylc
while the sea-ice DA is active.SOCA
is designed to handle different model types (ocean, sea-ice, BGC, waves), hence some of the configuration creation will depend on if these models are turned on or off. This is a longer term consideration but an important one as combinations of different model types are concerned.--no-requeue
#SBATCH
option to prevent Cylc tasks from resubmitting jobs and "spreading" to other compute nodes.Closes the following:
--no-requeue
flag to SLURM submissions #388