Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error reporting for empty channel lists #414

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Error reporting for empty channel lists #414

merged 5 commits into from
Sep 9, 2024

Conversation

asewnath
Copy link
Collaborator

@asewnath asewnath commented Aug 28, 2024 •
edited
Loading

Description

  • Adding descriptive logger aborts to get_channels for empty channel lists.
  • Adds/modifies code testing for generating observing system yaml files

Resolves #411.

@asewnath asewnath requested a review from ashiklom August 28, 2024 20:14
@ashiklom ashiklom mentioned this pull request Aug 28, 2024
Closed
@asewnath asewnath marked this pull request as draft August 28, 2024 20:36
@asewnath asewnath marked this pull request as ready for review September 3, 2024 19:39
@asewnath
Copy link
Collaborator Author

asewnath commented Sep 4, 2024

@ashiklom ready for review

@ashiklom
Copy link
Collaborator

ashiklom commented Sep 6, 2024

Two small suggestions, but otherwise, this looks good! Special thanks for putting together and enabling the code test!

@ashiklom ashiklom merged commit b021b93 into develop Sep 9, 2024
2 checks passed
@asewnath asewnath deleted the feature/missing_channel_list branch September 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiklom ashiklom ashiklom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_channels utilities are fragile and throw uninformative errors
2 participants
@asewnath @ashiklom