Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set tropopause pressure opt consistent w/ GSI #464

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Set tropopause pressure opt consistent w/ GSI #464

merged 3 commits into from
Dec 5, 2024

Conversation

rtodling
Copy link
Contributor

Description

This has been found sometime ago to be missing setting in SWELL. To be consistent w/ GSI we need to the Model2GeoVal to the formulation of GSI to calculate tropopause pressure.

Dependencies

None

Impact

None

@rtodling rtodling requested review from Dooruk and gmao-wgu November 22, 2024 16:01
@rtodling rtodling mentioned this pull request Nov 22, 2024
Open
@rtodling
Copy link
Contributor Author

rtodling commented Dec 5, 2024

@Dooruk Sorry to be asking for these ... but can we work to get this one in as well?

@rtodling rtodling added the enhancement New feature or request label Dec 5, 2024
@rtodling rtodling removed the request for review from gmao-wgu December 5, 2024 19:55
Dooruk
Dooruk approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: 3dvar fill fail due to a known issue.

@Dooruk
Copy link
Collaborator

Dooruk commented Dec 5, 2024

@rtodling which issues would this close?

@rtodling
Copy link
Contributor Author

rtodling commented Dec 5, 2024 •
edited
Loading

@rtodling which issues would this close?

@Dooruk there isn't an issue associated w/ this ... this is simply fixing an error in the setup and configurations used in the UFO. The default in UFO is to use a version of the tropopause pressure calculation that is not what we presently use.

@Dooruk Dooruk merged commit 7eacb97 into develop Dec 5, 2024
14 of 15 checks passed
@Dooruk Dooruk deleted the feature/rtodling/use_gsi_tropprs branch December 5, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dooruk Dooruk Dooruk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtodling @Dooruk