Fixed issue where heightOfBarometerAboveMeanSeaLevel was depending on z_boom_u #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… z_boom_u * z_boom_u was incorrectly used to calculate heightOfBarometerAboveMeanSeaLevel. * Added offset parameter for defining barometer height relative to gps
patrickjwright
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
@ladsmund this looks like a good catch! I must have previously assumed GPS height was the ice surface, and then I added the upper boom height to get barometer height.
However, yes if the GPS height is the actual height of the GPS instrument in the enclosure, and the barometer is co-located, then the true height is simply the GPS height (when barometer_height_relative_to_gps is 0, as you have the default set).
The important thing is to use the best-fit GPS height, which you have maintained.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue: #218