feat: add interface for /setup endpoint #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add redirect from the login page to the set-up page if the server is not set up.
…irect from the login page to the set-up page if the server is not set up.
LuukBlankenstijn
changed the title
Yoronex
requested changes
Oct 29, 2024
|
Final thing: please create a separate commit in this PR when it is approved to update changelog.md with your changes. Because this is an improvement of PP and not a major rework, it is part of a new minor release (so the y in the x.y.z versioning). |
…add redirect from the login page to the set-up page if the server is not set up.
Yoronex
requested changes
Nov 21, 2024
LuukBlankenstijn
force-pushed
the
feature/add-interface-for-setup
branch
from
2255547 to
c0a365c
Compare
Yoronex
approved these changes
Jan 12, 2025
| <Button | ||
| fluid | ||
| primary | ||
| size="large" | ||
| type="submit" | ||
| disabled={validator.isEmpty(passwordRepeat) || !validator.equals(passwordRepeat, password) || !validator.isStrongPassword(password)} |
There was a problem hiding this comment.
Instead of validator.isStrongPassword, why not use passwordIsValid? If isStrongPassword implements different constraints, the user has no clue what is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.