Feature/nfc update #421
Closed
Feature/nfc update #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added additional locales where they were still missing and improved naming of them.
JustSamuel
commented
Oct 19, 2024
apps/dashboard/src/modules/user/components/forms/ChangeNFCForm.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/user/components/forms/ChangeNFCForm.vue
Outdated
Show resolved
Hide resolved
Changed where the scanner is opened and removed the dialog and form scanner should now work on mobile chrome browsers
JustSamuel
commented
Oct 22, 2024
apps/dashboard/src/modules/user/components/UserSettingsComponent.vue
Outdated
Show resolved
Hide resolved
JustSamuel
commented
Oct 22, 2024
apps/dashboard/src/modules/user/components/UserSettingsComponent.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/user/components/UserSettingsComponent.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/user/components/UserSettingsComponent.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/user/components/UserSettingsComponent.vue
Outdated
Show resolved
Hide resolved
Addresses remarks made in the pull request by @JustSamuel
JustSamuel
commented
Oct 31, 2024
JustSamuel
commented
Oct 31, 2024
apps/dashboard/src/modules/user/components/UserSettingsComponent.vue
Outdated
Show resolved
Hide resolved
removed console.log and whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds NFC support to the dashboard and (in the future) the pos.
Related issues/external references
#351
Types of changes